Skip to content

feat(psbt): change default to accept witness UTXOs for non-segwit inputs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

davidkaplanbitgo
Copy link

@davidkaplanbitgo davidkaplanbitgo commented Jul 10, 2025

Default PSBT behavior now allows signing non-segwit inputs with witnessUtxos instead of requiring the full previous transaction. This reduces potential DDoS attack vectors by not requiring the storage of previous transaction data in the input map.

By updating the security vulnerabilities, we lost compatibility for node v14. I replaced that in the ci with node v20

Issue: BTC-2285

Default PSBT behavior now allows signing non-segwit inputs with witnessUtxos
instead of requiring the full previous transaction. This reduces potential
DDoS attack vectors by not requiring the storage of previous transaction
data in the input map.

Issue: BTC-2285
@davidkaplanbitgo davidkaplanbitgo requested a review from a team as a code owner July 10, 2025 16:55
davidkaplanbitgo and others added 2 commits July 10, 2025 13:00
Replace Node.js 14 with 20 in CI matrix configurations.

Issue: BTC-2285

Co-authored-by: llm-git <[email protected]>
@davidkaplanbitgo davidkaplanbitgo requested a review from a team as a code owner July 10, 2025 17:12
Copy link

@lcovar lcovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the way

@davidkaplanbitgo davidkaplanbitgo merged commit f8dd4a1 into master Jul 10, 2025
11 checks passed
@davidkaplanbitgo davidkaplanbitgo deleted the BTC-2285 branch July 10, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants